• Hi, Guest!
    Some images might be missing as we move away from using embedded images, sorry for the mess!
    From now on, you'll be required to use a third party to host images. You can learn how to add images here, and if your thread is missing images you can request them here.
    Do not use Discord to host any images you post, these links expire quickly!
Resource icon

Resource [20.1+] BP System 1.0.7

4AllNighterGrinder64

4 Sleepless nights to update to Teal Mask Part 1
Member
Joined
Nov 23, 2023
Posts
18
I assume the problem comes because both plugins edit pbEndOfBattle. I'll look at the terastallization code to see if it's the case.

Edit: Lucidious plugin does touch pbEndOfBattle but there should be no reason for my plugin to stop the terastallization from ending. I don't know why it's happening but I think I know a possible way to fix it.
I will try out the updated BP System soon. I will let you know if the conflict with terastallization is fixed.
 

Lucidious89

Champion
Member
Joined
Nov 12, 2020
Posts
1,047
I assume the problem comes because both plugins edit pbEndOfBattle. I'll look at the terastallization code to see if it's the case.

Edit: Lucidious plugin does touch pbEndOfBattle but there should be no reason for my plugin to stop the terastallization from ending. I don't know why it's happening but I think I know a possible way to fix it.
I didn't have the chance to look at the plugin before you updated it, but I imagine it was likely a load order issue, so my alias of this method was being overwritten instead of aliasing the method like it's supposed to.

Though, linking the BP acquisition to the same method that the player acquires money through seems like a much better and more logical way to go about it, anyway.

As a separate issue though, I notice that you're using the Essentials Deluxe compiler method for adding PBS info. That's fine, but unless your plugin depends on this to work, I would advise against this. Fiddling with how the compiler works is messy and very risky business, and leaves your plugin prone to compatibility issues. Which is why I abandoned that whole method of doing things in the new v21 plugin. It seems like your plugin implements all of this simply to provide an example for two items, which imo, is not worth all of that complex code when you can simply just post a picture of an example instead. But that's just my two cents.
 

LinKazamine

Champion
Member
Joined
May 24, 2023
Posts
614
I added the compiler thinking it would be easier to add the BP prices to items that way than to go through all the items in the files but if it causes trouble I have no issue taking it down and adding images on how they should be added.
 

4AllNighterGrinder64

4 Sleepless nights to update to Teal Mask Part 1
Member
Joined
Nov 23, 2023
Posts
18
I assume the problem comes because both plugins edit pbEndOfBattle. I'll look at the terastallization code to see if it's the case.

Edit: Lucidious plugin does touch pbEndOfBattle but there should be no reason for my plugin to stop the terastallization from ending. I don't know why it's happening but I think I know a possible way to fix it.
I have tested out 1.0.6 of the BP System plugin with all of the Deluxe Battle Kit plugins. Terastallization works as intended now. The plugin conflict with the previous version and the DBK Terastallization add on is now fixed. I forgot to test out Mega Evolution and Z-Moves on my end, but they were working fine before the update fixed the plugin conflict with Terastallization.
 

LinKazamine

Champion
Member
Joined
May 24, 2023
Posts
614
Well, that problem is carried from the v21 version since I didn't touch the line that causes it. I'll upload the fix but you can do it yourself by going to 02 - Shop/BP_Shop and deleting or commenting out line 341. The line in question is itemprice /= 2 if !@buying.
 

CelestialFearow

Venipede User
Member
Joined
Jul 24, 2020
Posts
196
Well, that problem is carried from the v21 version since I didn't touch the line that causes it. I'll upload the fix but you can do it yourself by going to 02 - Shop/BP_Shop and deleting or commenting out line 341. The line in question is itemprice /= 2 if !@buying.
Alright!
 
Back
Top