- Joined
- Jan 14, 2018
- Posts
- 6
I just updated my project to v21 and then saw this. The script itself doesn’t seem too different in that version compared to v20.1. Do you think this would be compatible?
havent checked v21 myself yet but hey you can always just test it out and remove it if it doesn't work i guess?I just updated my project to v21 and then saw this. The script itself doesn’t seem too different in that version compared to v20.1. Do you think this would be compatible?
I'll let you know how it goes!havent checked v21 myself yet but hey you can always just test it out and remove it if it doesn't work i guess?
if SHOW_IV_RATINGS
pbDisplayIVRatings(@pokemon, overlay, 110, 82)
end
pbDisplayIVRating
with no "s".Did an issue come up related to this?There appears to be a typo in Summary.rb:
Unless there's something I'm missing, I think this should just beRuby:if SHOW_IV_RATINGS pbDisplayIVRatings(@pokemon, overlay, 110, 82) end
pbDisplayIVRating
with no "s".
yo thank you for this, it saves some effort for when i go back to updating these after my vacation and other RL stuffTo make the plugin work with v21, replace what is inside the compiler.rb section (exept the modules calls at the beginning) by the
def validate_compiled_trainer(hash) script that is in the v21 essentials.
In this script remove the Pokemon::EV_LIMIT and Pokemon::EV_STAT_LIMIT or replace them by their correct number (I don't know where but the plugin set them to 0 where it should be 252 and 512).
The plugin looks perfectly functional
Yeah, I was helping someone who was running into it. SHOW_IV_RATINGS is set by BW Summary, so if you have BW Summary but not Enhanced UI you'll get an error for the undefined method. See below.Did an issue come up related to this?
Because this is an existing script belonging to the Enhanced UI plugin. it is only called if the SHOW_IV_RATINGS setting is enabled which is also an Enhanced UI setting, so it shouldn't cause an issue to anyone who doesn't have that plugin.
I don't think they just happen to overlap, it looks intentional to me, since the BW summary dev even writes below the SHOW_IV_RATINGS setting that this is meant to work in tandem with Lucidious' Enhanced UI pluginYeah, I was helping someone who was running into it. SHOW_IV_RATINGS is set by BW Summary, so if you have BW Summary but not Enhanced UI you'll get an error for the undefined method. See below.
It's unfortunate and confusing that BW Summary and Enhanced UI apparently overlap so much in their naming conventions (and even settings?).
View attachment 20212
No, its more confusing than that.I don't think they just happen to overlap, it looks intentional to me, since the BW summary dev even writes below the SHOW_IV_RATINGS setting that this is meant to work in tandem with Lucidious' Enhanced UI plugin
View attachment 20214
so either the person you were helping needs to get that plugin if they want to see the ratings or they can just set the setting to false and see the actual IV numbers which works fine...
Or I could just snatch that script and put it somewhere in my plugin but considering the BW summary dev didn't do it either I dont think its very ethical...
What I can easily fix is the error. I will make that part of the code be ignored if the Enhanced UI plugin is not installed so it will not try to find a nonexistent script.
like so
View attachment 20215
Well, it looks like there is still a small problem. You cannot manage your moveslots in the summary. It asks you if you want to give an item instead.yo thank you for this, it saves some effort for when i go back to updating these after my vacation and other RL stuff
elsif @page == 4
pbPlayDecisionSE
pbMoveSelection
dorefresh = true
Also the images are back in the original post!
interesting, i'll see the differences and test this out and if there are no issues i'll make a new v21 post for this and credit you because im not gonna lie, i wasnt feeling that motivated to deal with v21 until i saw your postin case someone else needs it, I'm posting here the link to my v21 version of the plugin, feel free to tell me if there are still bugs here:
File folder on MEGA
mega.nz
Thanks to grogro being more motivated than me at dealing with Essentials v21.1, the nessecary edits have been done to make this plugin compatible with it.
I also tested it with the BW Summary Screen and it seems to work!
Also added a fix (in both versions) posted above for not being able to select and swap moves if you were not using the BW Summary Screen.
Both v20.1 and v21.1 versions are accomodated in the same thread and the download link is a mediafire folder containing both. I...
I found out generation 9 pack was breaking the summary part of this plugin. Now it doesn't anymore.