I'm glad it worked out for you. Sorry it took so long and ended up being a pretty easy fix.
Eh, that's a new one. I'll look into it, but I've not noticed anything like that. Please check you called it with pbGainCharm and not pbGainElementCharm. I'll try to figure out how else that's possible, and try to put in some fail-safes, is that's the cause.
Please let me know if that was the cause. If not, I'm at a loss. It will currently allow you to put regular charms in the elemental case (obviously it shouldn't) but I didn't notice anything weird with the oval charm going into the right place. Using pbGainElementCharm(:OVALCHARM) did push it into the Elemental Case, though. I'll try to have a fix later tonight or tomorrow when I release an Evolution Charm (requires less levels to evolve) and Substitute's Seeker Charm(Instead of refreshing trainers on game continue, it will only allow you to reset daily), as well as a few other minior tweaks.
No worries. I'm still going to add a failsafe just incase. Thank you for pointing out a flaw on my end. A simple if statement seems to correct the problem and will cause the opposite gain to be called if the wrong type of charm.
EventHandlers.add(:on_wild_pokemon_created, :elemental_charm
proc { |pkmn|
for type in pkmn.types do
type = type + "CHARM"
if $player.activeCharm?(type)
typeMatch = true
end
end
if typeMatch
stats = [:HP, :ATTACK, :DEFENSE, :SPECIAL_ATTACK, :SPECIAL_DEFENSE, :SPEED]
for stat in stats do
pkmn.iv[stat] += 10
pkmn.iv[stat] = [pkmn.iv[stat] + 10, Pokemon::IV_STAT_LIMIT].min
end
pkmn.calc_stats
end
}
)if typeMatch for anything else you can modify for a pokemon.As of right now, I don't much plan on adding anything as I kind of burnt myself out. I had no intention of adding tera type data, as it wasn't common when I make the Case in the first place. As always, LinKazamines solution should work for the first part of what you would like. I am still open to helping people add their own Charms, just PM me and I'll help you through the process. If I get enough extra Charms to add, I might update the Case with new Charms in it, I just ran out of ideas.
Is there any chance you can update this to fix an issue I had with another plugin? I remembered Orange's Nature Expansion and I have two issues with Charm Case and it.
The second one happens when I pick up any charm other than the elemental ones. In this case, if I pick up an elemental charm first along with the charm case, no error occurs.
Why do you have both the Charms Case and Charms Compilation installed? They are the same. Having them both will probably cause that error and more.
