I will look into it. It was written for 20.1 but I tested on a clean 21.1 to check it out. I will mark it as 20.1 until I can figure out the issues.
Temporarily fixed the problem with the black/white flute issue for V21.1. I will look into putting into a more permanent fix. In the meantime, please let me know if you run into anymore errors.
$player.activeCharm? to check if the charm is active instead of checking if it's in the bag. I haven't looked at all of them, but on the Healing Charm code you have one $bag.has?(:HEALINGCHARM). Seeing how your script works, the healing of this charm will never happen since the charm will never be on the bag.$bag.has? is used on your script to make sure all your charms use the other code instead.Thanks. Oversight on my part. I was trying to debug the problem I was having with getting it to work, forgot to change it back. Fixed and re-uploaded.
The Coin Charm is meant to multiply coins.
Will absolutely look into doing this. It would be a great idea who people who don't like the item idea.
#===============================================================================
# Clover Charm / Key Charm / Viral Charm / Smart Charm / Spirit Charm
#===============================================================================
alias charm_pbGenerateWildPokemon pbGenerateWildPokemon
def pbGenerateWildPokemon(species, level, isRoamer = false)
genwildpoke = charm_pbGenerateWildPokemon(species, level, isRoamer)
items = genwildpoke.wildHoldItems
first_pkmn = $player.first_pokemon
# Clover Charm
if $player.activeCharm?(:CLOVERCHARM)
if first_pkmn
if $player.activeCharm?(:CLOVERCHARM)
chances = [60, 20, 5]
elsif $player.activeCharm?(:CLOVERCHARM) && (first_pkmn.ability_id == :COMPOUNDEYES || first_pkmn.ability_id == :SUPERLUCK)
chances = [75, 35, 15]
end
end
itemrnd = rand(100)
if (items[0] == items[1] && items[1] == items[2]) || itemrnd < chances[0]
genwildpoke.item = items[0].sample
elsif itemrnd < (chances[0] + chances[1])
genwildpoke.item = items[1].sample
elsif itemrnd < (chances[0] + chances[1] + chances[2])
genwildpoke.item = items[2].sample
end
end
genwildpoke.givePokerus if ($player.activeCharm?(:VIRALCHARM) && rand(100) < 10)
# Spirit Charm
if $player.activeCharm?(:SPIRITCHARM)
if !isRoamer && (Settings::MORE_ABILITIES_AFFECT_WILD_ENCOUNTERS || (rand(100) < 50))
genwildpoke.nature = first_pkmn.nature
end
end
# Smart Charm
if ($player.activeCharm?(:SMARTCHARM) && rand(100) < 30)
specialmoves = genwildpoke.species_data.tutor_moves + genwildpoke.species_data.get_egg_moves
genwildpoke.learn_move(specialmoves.sample)
end
return genwildpoke
end
#===============================================================================
# Twin Charm / Coin Charm if you want to add pbReceiveCoins method to put random coins on the ground
#===============================================================================
alias charm_pbItemBall pbItemBall
def pbItemBall(item, quantity = 1)
quantity *= 2 if event_name[/hiddenitem/i] && $player.activeCharm?(:TWINCHARM)
charm_pbItemBall(item, quantity)
end
#===============================================================================
# Gold Charm
#===============================================================================
class Battle
alias charm_pbGainMoney pbGainMoney
def pbGainMoney
return if !@internalBattle || !@moneyGain
@field.effects[PBEffects::PayDay] += 1000 if $player.activeCharm?(:GOLDCHARM)
charm_pbGainMoney
end
endI do appreciate the feedback. I will try to address any concerns as best as possible, but as LinKazamine said, there's hundreds of scripts out there, and it'd be impossible to make them all compatible with each other. I will add a disclaimer on the front page with all the modifications.If you PM me with your issues, I'll do my best to try and help you through the coding to get your game where you want it to be, while still enjoying all the plugins. I will look into adjusting the script.
Make sure your twin charms defines the event_name
#===============================================================================
# Twin Charm / Coin Charm if you want to add pbReceiveCoins method to put random coins on the ground
#===============================================================================
alias charm_pbItemBall pbItemBall
def pbItemBall(item, quantity = 1)
event_name = $game_map.events[@event_id].name # Use the event_id to get the event and its name
quantity *= 2 if event_name[/hiddenitem/i] && $player.activeCharm?(:TWINCHARM)
charm_pbItemBall(item, quantity)
end