Resource After-Battle Commentary 1.1.1

[Yumil]

Yumil submitted a new resource:

After-Battle Commentary - Allow NPCs to comment on the outcome/various propertie of a battle through a series of flags/checks.

Ever wished the game could acknowledge the player's play style in some capacity ? Acknowledge that the player just swept your important NPC's team without breaking a sweat ? Maybe reward them for that with a rare item ? Or instead call them out for spamming healing items to win ? Have recurring opponents note how much the player's team changed since last time they fought ? Have them comment on how this new addition to the player's team totally made the difference, or how it's strange how...

Read more about this resource...

 

[Izanagi]

This is such a cool concept! Will definitely use this. Thanks for your work, man!

 

[thebigguy270]

You could pull a Psycho Mantis with this

 

[Yumil]

You probably could ! Nothing prevents you from checking the content of the registered battles through a good old script call and do some treatment with the accumulated data.

 

[Yumil]

Yumil updated After-Battle Commentary with a new update entry:

V1.1-Winning by a thread, Detecting move spam

Got some feedback with some really good suggestions in it, so I tried to implement them as fast as I could!

Change log :

New features:
-added another possible flag to the overall result function, "BY_A_THREAD" - it procs if you manage to win with only one pokemon remaining, and said pokémon is at 25% or less health. Now you can have your NPC seethe at the player for clearly getting away right when you had them !

-Added a whole new feature that tracks the moves used by the player...

Read the rest of this update entry...

 

[Yumil]

Yumil updated After-Battle Commentary with a new update entry:

V1.1.1-oops

-Forgot to make the constructor of the battle class assume the recorded and team sizes attributes were nil - this crashed the wild battles. It's back up now.

-Forgot to include the descriptions of the 1.1 flags to the documentation - mistake corrected.

Read the rest of this update entry...

 

[REALMUGEN]

Very interesting script...

I have this error

[Pokémon Essentials version 19.1]
[Generation 8 Project v1.1.2]
[EBDX v1.2.6]

Exception: RuntimeError
Message: Script error in event 2 (coords 10,11), map 66 (Safari Zone):
Exception: ArgumentError
Message: wrong number of arguments (given 5, expected 7)

***Full script:
 pbSingleOrDoubleWildBattle(:TANGELA,16, $game_map.events[2].map.map_id, $game_map.events[2].x, $game_map.events[2].y,1,0,false)

Backtrace:
[After Battle NPC Commentary] 001-ScriptOverrides.rb:132:in `initialize'
231:Overworld_BattleStarting:280:in `new'
231:Overworld_BattleStarting:280:in `pbWildBattleCore'
393:Visible Overworld Wild Encounters:957:in `pbWildBattle'
[Elite Battle: DX] EBDX Randomizer.rb:274:in `pbWildBattle'
[Elite Battle: DX] Class Overrides.rb:66:in `pbWildBattle'
393:Visible Overworld Wild Encounters:913:in `pbSingleOrDoubleWildBattle'
(eval):1:in `execute_script'
033:Interpreter:140:in `eval'
033:Interpreter:140:in `execute_script'


Backtrace:
033:Interpreter:192:in `rescue in execute_script'
033:Interpreter:138:in `execute_script'
034:Interpreter_Commands:352:in `command_111'
034:Interpreter_Commands:29:in `execute_command'
033:Interpreter:130:in `block in update'
033:Interpreter:87:in `loop'
033:Interpreter:87:in `update'
[Following Pokemon EX] Refresh.rb:252:in `update'
032:Scene_Map:157:in `block in update'
032:Scene_Map:155:in `loop'

Do you know if it has to do with Visible Overworld Wild Encounters or EBDX?

Thank you very much for sharing

 

[TechSkylander1518]

Message: wrong number of arguments (given 5, expected 7) ***Full script: pbSingleOrDoubleWildBattle(:TANGELA,16, $game_map.events[2].map.map_id, $game_map.events[2].x, $game_map.events[2].y,1,0,false)

It doesn't have anything to do with this script - pbSingleOrDoubleWildBattle isn't referred to anywhere in this resource, or even base Essentials, it's a method exclusive to Visible Overworld Wild Encounters.

 

[Yumil]

oh I also missed posts here what the hell

anyway sorry for the delayed answer but

Very interesting script...

I have this error

[Pokémon Essentials version 19.1]
[Generation 8 Project v1.1.2]
[EBDX v1.2.6]

Exception: RuntimeError
Message: Script error in event 2 (coords 10,11), map 66 (Safari Zone):
Exception: ArgumentError
Message: wrong number of arguments (given 5, expected 7)

***Full script:
 pbSingleOrDoubleWildBattle(:TANGELA,16, $game_map.events[2].map.map_id, $game_map.events[2].x, $game_map.events[2].y,1,0,false)

Backtrace:
[After Battle NPC Commentary] 001-ScriptOverrides.rb:132:in `initialize'
231:Overworld_BattleStarting:280:in `new'
231:Overworld_BattleStarting:280:in `pbWildBattleCore'
393:Visible Overworld Wild Encounters:957:in `pbWildBattle'
[Elite Battle: DX] EBDX Randomizer.rb:274:in `pbWildBattle'
[Elite Battle: DX] Class Overrides.rb:66:in `pbWildBattle'
393:Visible Overworld Wild Encounters:913:in `pbSingleOrDoubleWildBattle'
(eval):1:in `execute_script'
033:Interpreter:140:in `eval'
033:Interpreter:140:in `execute_script'


Backtrace:
033:Interpreter:192:in `rescue in execute_script'
033:Interpreter:138:in `execute_script'
034:Interpreter_Commands:352:in `command_111'
034:Interpreter_Commands:29:in `execute_command'
033:Interpreter:130:in `block in update'
033:Interpreter:87:in `loop'
033:Interpreter:87:in `update'
[Following Pokemon EX] Refresh.rb:252:in `update'
032:Scene_Map:157:in `block in update'
032:Scene_Map:155:in `loop'

Do you know if it has to do with Visible Overworld Wild Encounters or EBDX?

Thank you very much for sharing

so I have no experience with Visible Overworld and have no idea how it works under the hood but tthere's a very real chance it might not play nice with my resource because I didn't knew a couple things about passing optionnal parameters when I made this

but one thing that's puzzling me is that my resource does show up in the backtrace, but... there's no initialize anywhere line 132 in scriptsOverrides.rb, though ?

Is it possible per chance you weren't using the up-to-date version when you tried this ? Do you still get this crash ?

I understand i'm like two months late but if you still have this problem let me know I've learned a couple useful things about optionnal parameters since and I might be able to fix the thing and futureproof the resource if this is indeed the problem.