Yeah, the damage calc refactor is dramatically important, both for DBK and every plugin that relies upon DBK. Almost nothing related to battles will work without it.
Idk, ive never encountered either of these issues, nor can I seem to replicate either of them now. Do you have any other plugins or custom edits that affect the damage calc or HP calc formulas?
To test, I set up a wild Blissey with around 15,000 HP and attacked it with a move that dealt around...
#-----------------------------------------------------------------------------
# Gets Ultra item for this species.
"getUltraItem" => proc { |pkmn|
next :ULTRAPYRIUMZ if pkmn.form = 0
next :ULTRAKPYRIUMZ if pkmn.form = 1
},
It's supposed to be == not =. That's all the problem is.
Idk, I set up some dummy tests for both Electrode and Pyroar and it works fine for me. I will say though that what youre trying to set up is really complicated and messy, and I suspect that the fact that youre unfamiliar with form handlers must compound the confusion.
The only generic advice I...
Does Pyroar already have an existing MultipleForms handler?
Regional forms typically already use a MultipleForms handler in order to force them into the correct form based on the region youre in. It's likely that they're overwriting each other.
Status moves arent meant to be used as base moves for exclusive Z-Moves. Only damage-dealing moves are meant for that.
Status moves have their own specific and unique interaction with Z-Power, which just provides them an additional effect and changes their name to Z-whatever (Z-Growl, Z-Leer...
Gotcha. Ok, then it should be good now. However, the "getDataPageInfo" section of your code is broken. Although, thats only really important if you have the Pokedex Data Page plugin installed.
You can apply as many unique battle rules as you want to a single battle. They will just overwrite each other if they affect the same thing.
Like, applying both the "canRun" and "cannotRun" battle rules will overwrite each other. Applying the "weather" rule to Sun and then applying it again to...
Why do you have two different midbattle script rules set? They will always overwrite each other if that's the case. A battle can only have ONE midbattle script.
Sure. I mean, Necrozma already technically has two different Ultra Burst forms, since Dusk Mane (form 1) and Dawn Wings (form 2) Necrozma each Ultra Burst into their own forms (3 and 4, respectively). The only difference is that forms 3 and 4 are identical, in this case (Ultra Necrozma).
This has nothing to do with DBK. The error doesn't point to any of the plugin scripts. It seems more like an error with some custom edits in your Essentials scripts.