v20.1 Fame Checker [v19/v20] 2.1.1

• Update
  • Added the ability to display a message for the player when having found all of the pieces of info for a famous person This basically means that as of now, all of the default features that were within the original version are now implemented. I have also added a switch within the userFunctions.rb file to exclude the new feature if wanted. This also means that you can modify this value within the debug menu.
• Hope everybody has enjoyed using this plugin so far, but I've run out of ideas to add more to it, so unless I get some more ideas from the community, I think this plugin will be put into maintenance mode for the time being.
  Seriously, thanks for even taking the time to check it out, I really enjoyed every moment of developing this

The main purpose of this update is to make it even easier to use. Thus I have created a way to change the fame_targets.txt data from the debug menu, that being said, let's get onto the stuff

• Bug Fixes
  • A small bug fix with the Save Parity system in which some data would be written to the compiled data, this doesn't cause any issues because the data that was written to isn't actively called during operation, and is furthermore deleted upon ending the program.
• Warning
  • If you plan on updating, please force your game to recompile once before using the debug menu, this is because I have added a new element to the compiled data which must be accounted for.
• Compiler Updates
  • The compiled got some updates, new guards to further reduce the possibility of data being incorrectly assigned, code clean up which makes it much easier to follow, and the ability to write the compiled data to the fame_targets.txt file.
• Debug Menu
  • The debug menu uses the same debug menu functions that the rest of the menu uses. This proved to be an interesting challenge because of how complex it was. That being said, to access it all you need to do is go to the information editors section, it'll be at the bottom titled Edit Fame Data...
• Side Node
  • This is the first time I actually had a major difference in how something worked in v19 vs v20, it wasn't major I just thought it would be an interesting talking point.

Well, I kinda left a big bug in the code that a doubt anybody would have found until they screwed up at least one save file. I found it because I was telling a friend about this project and something I was talking about made me realize the issue. It was a really problematic bug. If you removed or added any info elements not at the end, the save would de-sync. This is also true if you remove and add elements at the same time, or swap elements around. Unfortunately, if you broke your save file in this way, I cannot fix it as the implementation needs to create a new save element. If you didn't break your save file, however, you can update and it will automatically change the save file to make sure you can't break it in the future. Anyways...

• Bug Fixes
  • Fixed the large issue with save parity
  • Fixed a small bug where the first element would animate while still selecting a famous person
• Limitations
  • Because of this implementation, if you change the [] part of an element, it will be reset to it's default value, as the key no longer exists. If you want to change the name of an element, you might want to change the display name(Name =) in the PBS file
• Updates
  • Added the ability to modify the display name of famous people. Keep in mind that if the name was modified, it will continue to be that name as it is saved to the save file. There are also included functions to get the display name as well as remove the display name.
  • Added the ability to put the item into the favorites menu. If you plan on using the actual item, then this will enable your players to favorite it if they want.
  • Slightly changed the user functions so that Strings(which convert to Symbols) can be used

This release is a small update that most people probably won't need, however a user expressed that they want to be able to modify where the PBS files are located, so I made it possible. In addition I got rid of the annoying error message that happens on first launch, it shouldn't affect anything if you have already been using Version 2.0.2.

I can't believe I left so many small bugs in the code. I had thought that I had made sure there were no bugs, but... apparently not. This time it was one that is really important to fix. as it turns out, I had it do the save parity update only when the PBS file was compiled, an end user would never be able to do this save parity update if so, I really should have tested the code in the game.exe variation as well... At least I found this one before anybody brought it to me.

I am just a bit of an idiot, I forgot to ensure that $PokemonGlobal.FamousPeople actually existed before trying to manipulate it. I feel like a small bit of an idiot. To be fair, because of the way I was testing conversion from old to new, I'm pretty sure my save file already had $PokemonGlobal.FamousPeople initialized, I will have to be more careful with that in the future.

oh boy, that was a surprising amount of work. Well either way, the major update v2.0.0 is done and ready to be downloaded on my GitHub. Lots of things changed, from changing the entire code base, to adding new features. This update in total took up a good chunk of time. Anyways, lets get onto the Updates.

• I updated how the info sprites are loaded, they can now be animated, and can grab files from anywhere,
• Also updated the device sprites so that they could be loaded from anywhere as well,
• Increased the total size of everything to account for larger sprites, info now have a max frame size of 64x64, and max device size of 222x164
• Fixed some of the centering issues with the select box that was happening with the previous version,
• Deprecated all of the old functions that served as data entry,
• Renamed a lot of the user functions to better reflect what they do,
• Created a game switch to check if every piece of info and famous person has been found,
• Because I changed the save system a bit, I created a conversion system from old to new. An important thing to note is that all pieces of info must be in the same position as the old save,
• and the big one, Created a PBS style input system which removes as much coding knowledge requirement as possible. The readme and the PBS file itself have instructions on how to use it. However, the easiest way to see it is by going over to the main GitHub page

Please tell me if anybody has any issues or encounters bugs with the code, or has any suggestions for improvement.